This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: structural search always streams by default#40872
Merged
Conversation
26d220e to
6d6513c
Compare
rvantonder
commented
Aug 25, 2022
| } | ||
|
|
||
| // For structural search with default limits we retry if we get no results. | ||
| // For batching structural search we use retry logic if we get no results. |
Contributor
Author
There was a problem hiding this comment.
We can probably get rid of the batching retry logic below, but this PR focuses on fixing the hot path.
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 7fc215a...6d6513c.
|
tbliu98
approved these changes
Aug 25, 2022
Member
|
Nice.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural search doesn't stream by default (in global mode or when
countis not set). I really think I remember seeing global structural search on Sourcegraph.com in a past so this feels like a regression, but I really can't find any evidence. Maybe we've just always had this issue.Test plan
unit test and
backend-integrationtests