This repository was archived by the owner on Sep 30, 2024. It is now read-only.
migrator: Update concrete runner factory#39553
Merged
Merged
Conversation
eseliger
approved these changes
Jul 27, 2022
This was referenced Jul 27, 2022
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff cc0bb8e...47a55b2.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduced an (initially unused) type
RunnerFactoryWithSchemasand rewrites the concrete runner factories in the sg migration and migrator commands in terms of this new constructor.Test plan
Existing tests.