This repository was archived by the owner on Sep 30, 2024. It is now read-only.
migration: Generate upgrade paths statically and make available in migrator#39546
Merged
Conversation
This was referenced Jul 27, 2022
50d84cc to
8392b29
Compare
eseliger
approved these changes
Jul 27, 2022
| var MinVersion = oobmigration.NewVersion(3, 29) | ||
|
|
||
| // MaxVersion is the highest known released version at the time the migrator was built. | ||
| var MaxVersion = oobmigration.NewVersion(3, 42) |
Member
There was a problem hiding this comment.
does this need to become a release step?
Member
There was a problem hiding this comment.
Also, could we derive it from version.Version() so it's not manual? I assume not, it would not return anything useful for dev builds though :/
Contributor
Author
There was a problem hiding this comment.
I'm also concerned about this max, but I think I can baby site it for a release or two until we can unify things like that, the appropriate src-cli patch version, etc.
Co-authored-by: Erik Seliger <erikseliger@me.com>
Co-authored-by: Erik Seliger <erikseliger@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a file into git about upgrade metadata that can be baked into the migrator binary. This will be used by a future
sg migration upgrade/migrator upgradecommand without requiring access to the Sourcegraph repository clone (what the current stitch tooling is built on top of).Test plan
Checked output manually.