This repository was archived by the owner on Sep 30, 2024. It is now read-only.
ci: only ignore scripts with yarn in the deduplicate script#39519
Merged
Conversation
This fixes the `sourcegraph-async` breakage introduced in #39454: most invocations of `yarn` that were replaced by `yarn-install-with-retry.sh` did not disable lifecycle scripts, but the new unified `yarn-install-with-retry.sh` script did globally. This moves the `--ignore-scripts` flag back into the only script that actually used it, which is `yarn-deduplicate.sh`.
jhchabran
approved these changes
Jul 27, 2022
jhchabran
left a comment
Contributor
There was a problem hiding this comment.
Oh my bad @LawnGnome, thanks for catching this 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
sourcegraph-asyncbreakage introduced in #39454: most invocations ofyarnthat were replaced byyarn-install-with-retry.shdid not disable lifecycle scripts, but the new unifiedyarn-install-with-retry.shscript did globally. This moves the--ignore-scriptsflag back into the only script that actually used it, which isyarn-deduplicate.sh.Test plan
CI only; will be verified by a green
sourcegraph-asyncrun.