This repository was archived by the owner on Sep 30, 2024. It is now read-only.
phabricator: Simplify repo create#39487
Merged
Merged
Conversation
We no longer need to perform a remote call from repo-updater in order to create a Phabricator repo, we can simply call the DB directly. This removes the need for an internal handler in frontend to talk to the DB as well as the client code to call this handler.
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a2a661f...0ee0d6a.
|
eseliger
approved these changes
Jul 27, 2022
eseliger
left a comment
Member
There was a problem hiding this comment.
Nice! This finally closes the ticket, right?
Contributor
Author
Yep! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need to perform a remote call from repo-updater in order to
create a Phabricator repo, we can simply call the DB directly. This
removes the need for an internal handler in frontend to talk to the DB
as well as the client code to call this handler.
Part of https://github.com/sourcegraph/sourcegraph/issues/36290
Test plan
All tests still pass