This repository was archived by the owner on Sep 30, 2024. It is now read-only.
oobmigration: Add additional behavior around versions#39474
Merged
Conversation
This was referenced Jul 27, 2022
eseliger
approved these changes
Jul 27, 2022
| } | ||
|
|
||
| func (v Version) GitTag() string { | ||
| return fmt.Sprintf("v%d.%d.0", v.Major, v.Minor) |
Contributor
Author
There was a problem hiding this comment.
No, we only track major/minor in oobmigration tables, so you can't actually introduce one in a patch (I think that's explicitly documented but I should double-check).
Also the way we're handing upgrades will be some version -> minor version, zero patch, and then you can do the regular update flow to your patch version if you want to (literally just migrate to X.Y.0, then launch X.Y.Z and the migrator will do the small, if any, schema upgrade).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new functions to the oobmigration package to help with version operations.
Test plan
New unit tests.