This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Create simple page for lockfile index#39427
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff fea76e9...eafb5b9.
|
eseliger
approved these changes
Jul 26, 2022
Comment on lines
+539
to
+541
| func (s *Service) DeleteLockfileIndexByID(ctx context.Context, id int) error { | ||
| return s.dependenciesStore.DeleteLockfileIndexByID(ctx, id) | ||
| } |
| RETURNING repository_id, commit_bytea, lockfile | ||
| ` | ||
|
|
||
| const deleteLockfileReferencesQuery = ` |
Member
There was a problem hiding this comment.
are there no overlaps in these three columns ever, ie. is this guaranteed to never be deleting any other lockfiles data?
If so, could this be a composite foreign key, by which we would also get the cascading delete done by the DB layer.
Contributor
Author
There was a problem hiding this comment.
Yeah, there's a unique index on these three.
If so, could this be a composite foreign key, by which we would also get the cascading delete done by the DB layer.
Good idea!
efritz
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a detail page for a single lockfile index and a mutation to delete them.
Of course there should/will be more information on that page, but baby steps.
Test plan
screenshot_2022-07-26_16.56.04.mp4
App preview:
Check out the client app preview documentation to learn more.