This repository was archived by the owner on Sep 30, 2024. It is now read-only.
notebooks: improvements to the read-only mode#39407
Merged
Merged
Conversation
fkling
approved these changes
Jul 26, 2022
| } | ||
|
|
||
| :global(.is-read-only-notebook) &:hover { | ||
| border: 1px solid transparent; |
Contributor
There was a problem hiding this comment.
You could probably just to border-color: transparent, but no big deal.
benvenker
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
Screenshots
Current read-only mode:
New read-only mode:
Demo
Left - new read-only mode, Right - old read-only mode
Screen.Recording.2022-07-26.at.09.46.55.mp4
Test plan
App preview:
Check out the client app preview documentation to learn more.