This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Search backend: add structured diff to CommitMatch result#39383
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff fc15e8f...ee0908d.
|
a63f7b0 to
ee0908d
Compare
rvantonder
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just constructs
CommitMatchwith an additional field that is the structured form of the diff rather than the textual form. The text form and structural form can be converted into each other without any loss of information, so in time, we should be able to remove the textual diff from the result type.I want this available for
file:contains()on diff searches, which is why I'm spending a little time on this now.Test plan
Updated existing tests. Things that are worth adding tests for were added in previous PRs.