This repository was archived by the owner on Sep 30, 2024. It is now read-only.
lib/group: fix race condition in test#39340
Merged
Merged
Conversation
This test has a race condition. It can be triggered consistently by
adding a `defer func() { time.Sleep(100 * time.Millisecond) }()` before
the `defer close(synchronizer)`. Unfortunately, I don't think it's
possible to completely remove the race condition without extending the
API of the group, so in this commit I resort to adding a sleep that
makes hitting the race condition vanishingly unlikely.
unknwon
approved these changes
Jul 25, 2022
unknwon
left a comment
Contributor
There was a problem hiding this comment.
Would be great if we add your PR description to as a code comment, so people understand why a sleep is necessary here.
Member
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has a race condition. It can be triggered consistently by
adding a
defer func() { time.Sleep(100 * time.Millisecond) }()beforethe
defer close(synchronizer). Unfortunately, I don't think it'spossible to completely remove the race condition without extending the
API of the group, so in this commit I resort to adding a sleep that
makes hitting the race condition vanishingly unlikely.
Test plan
Tested that the race condition is not hit with an added sleep.