This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Make password policy a standard feature#39213
Merged
Merged
Conversation
b91c026 to
64af14b
Compare
01cb735 to
88e93dd
Compare
eseliger
reviewed
Jul 22, 2022
eseliger
left a comment
Member
There was a problem hiding this comment.
did a pass, looks good so far, I think the linter / formatter will have a couple opinions on the indentation and such, did you configure eslint and prettier in your editor? Otherwise I'd strongly recommend using them as they make your life much easier :)
Other than that, I added a bunch of comments, mostly questions and some ideas thrown around, feel free to ignore them if you don't agree.
442d79d to
5bcba80
Compare
48327de to
b47118b
Compare
mrnugget
approved these changes
Jul 26, 2022
mrnugget
left a comment
Contributor
There was a problem hiding this comment.
👍 Only reviewed the Go parts. Left some suggestions, some of them nitpicky, but I think you should do another round on the tests to make them a bit more consistent with the rest of our codebase.
added 9 commits
July 26, 2022 14:31
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
4633c61 to
da4da25
Compare
ferozsalam
approved these changes
Jul 26, 2022
Contributor
|
Congrats! I think this is CHANGELOG-worth 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add the, now experimental, password policy feature as a standard feature.
Test plan