This repository was archived by the owner on Sep 30, 2024. It is now read-only.
dev/sg/check: fix Runner tracing#39197
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff d75a373...813d94e.
|
841c2ac to
f7fe020
Compare
f7fe020 to
f9c7591
Compare
Contributor
|
@bobheadxi this PR may be a good opportunity to fix the typo the instrumentation in https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/dev/sg/internal/analytics/tracer.go?L25:52 ! |
Member
Author
|
Ah good catch @jhchabran , fixed! |
…runner-tracing-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some funky data in Honeycomb, this improves the tracing in
check.Runnera bit:Runnerentrypoint has a top-level spanTest plan