This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Move git-extras functionality to the core workflow#39133
Merged
Conversation
philipp-spiess
approved these changes
Jul 26, 2022
Contributor
Author
|
Thank you for your review, @philipp-spiess! |
jjinnii
approved these changes
Jul 27, 2022
jjinnii
left a comment
Contributor
There was a problem hiding this comment.
LGTM! As you've already denoted, there are a few things that will likely be subject to change in future PRs (action icon, commit/diff views) but this looks great in the interim to move forward on bringing feature parity into the core product.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/39433
extensionsAsCoreFeaturesexperimental feature).This PR migrates only blame for the whole file mode and omits blame for selected lines mode. Whether we migrate the latter or not depends on the updates to the git blame UI (see this comment) and will be addressed (if needed) in the follow-up PRs.
In the file view, blame decorations are displayed only in the column view (see https://github.com/sourcegraph/sourcegraph/pull/36007).
The only UI change is that git blame icon migrated from the action items bar (extensions sidebar) to the repo header section (see screenshots).
Loom
Screenshots
Test plan
sg startextensionsAsCoreFeaturesexperimental featureApp preview:
Check out the client app preview documentation to learn more.