This repository was archived by the owner on Sep 30, 2024. It is now read-only.
docs: Update code nav images#39109
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a8ddadc...9b676a3.
|
efritz
reviewed
Jul 26, 2022
| - **code files on your code host**, via [integrations](../integration/index.md) | ||
|
|
||
|  | ||
|  |
Contributor
There was a problem hiding this comment.
Spelling error at covde. Since these are new files could we also put them in a code-graph/docs directory instead of in the root of the sg-assets bucket? That place is a mess.
Contributor
Author
There was a problem hiding this comment.
Added the images to git ✅
I must be remembering a stale recommendation to put images in sourcegraph-assets.
Contributor
There was a problem hiding this comment.
No, they should be but just organized in some way. I think we already have some suitable subdirs.
Contributor
Author
There was a problem hiding this comment.
🤦♂️ Moving back to the sourcegraph-assets bucket in https://github.com/sourcegraph/sourcegraph/pull/39469
efritz
approved these changes
Jul 26, 2022
cesrjimenez
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/sourcegraph/sourcegraph/issues/31306
Test plan
N/A