Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Remove deprecated campaigns leftovers#25783

Merged
eseliger merged 9 commits into
mainfrom
es/remove-campaigns
Oct 20, 2021
Merged

Remove deprecated campaigns leftovers#25783
eseliger merged 9 commits into
mainfrom
es/remove-campaigns

Conversation

@eseliger

@eseliger eseliger commented Oct 7, 2021

Copy link
Copy Markdown
Member

See the individual commits for the steps. I also adjusted the docs a bit and added changelog entries. Src-cli PR deleting the two deprecated subcommand aliases is also up.

This executes what we state in the deprecation notice in 3.33.

@cla-bot cla-bot Bot added the cla-signed label Oct 7, 2021
@eseliger eseliger force-pushed the es/remove-campaigns branch 2 times, most recently from 3f13dc5 to b154231 Compare October 19, 2021 21:27
@eseliger eseliger marked this pull request as ready for review October 19, 2021 21:31
@eseliger eseliger requested review from a team and malomarrec October 19, 2021 21:31
@sourcegraph-bot

sourcegraph-bot commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Notifying subscribers in CODENOTIFY files for diff 094da5f...e595f81.

Notify File(s)
@christinaforney doc/batch_changes/references/name-change.md
@keegancsmith internal/conf/computed.go
@limitedmage client/web/src/search/panels/utils.ts

Comment thread cmd/frontend/graphqlbackend/batches.graphql
Comment thread CHANGELOG.md Outdated

@mrnugget mrnugget left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diff!

Comment thread doc/batch_changes/references/name-change.md Outdated
Comment thread doc/batch_changes/references/name-change.md Outdated
@eseliger eseliger force-pushed the es/remove-campaigns branch from 0d27954 to e595f81 Compare October 20, 2021 10:27
@eseliger eseliger enabled auto-merge (squash) October 20, 2021 10:28
@eseliger eseliger merged commit 1539125 into main Oct 20, 2021
@eseliger eseliger deleted the es/remove-campaigns branch October 20, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants