This repository was archived by the owner on Sep 30, 2024. It is now read-only.
httpcli: log when SystemCertPool fails to load#22285
Merged
Merged
Conversation
We are seeing an issue where configuring TlsExternal.Certificates seems to lead to the system cert pool not being used. eg can communicate with internal github enterprise, but communication with github.com fails. Add this log line to debug a potential cause.
ryanslade
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing an issue where configuring TlsExternal.Certificates seems
to lead to the system cert pool not being used. eg can communicate with
internal github enterprise, but communication with github.com fails. Add
this log line to debug a potential cause.
Related to https://github.com/sourcegraph/sourcegraph/issues/71