Notifying subscribers in CODENOTIFY files for diff 1851376...ffa11b5.

No notifications.

Codecov Report

Merging #17034 (ffa11b5) into main (1851376) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #17034      +/-   ##
==========================================
- Coverage   51.98%   51.98%   -0.01%     
==========================================
  Files        1703     1703              
  Lines       84786    84788       +2     
  Branches     7524     7666     +142     
==========================================
- Hits        44079    44077       -2     
- Misses      36806    36808       +2     
- Partials     3901     3903       +2     

@bobheadxi You can use something like &time=1609931477000&time.window=3600000 instead, check https://grafana.com/docs/grafana/latest/dashboards/time-range-controls/#control-the-time-range-using-a-url

I considered that (see PR description):

An alternative is time and time.window, but that might not be great for alerts lasting longer.

It's not a great experience if the alert spans, say, 24 hours of problems (the link would only show a few minutes or whatever value we set there)

I see, I did not notice that in the body my bad. I think defaulting to 1h or inferring time.window from something like the alert period * 1.5 should be ok.

Eg if CPU utilization alerts when its > 50 for 5m we link to a dashboard of time of alert and time.window of 7.5m

inferring time.window from something like the alert period * 1.5 should be ok.

Unfortunately you cannot do arithmetic in alertmanager templates :/ However, I think I found a nice middle-ground strategy with e3f166f:

• If start and end available, link to a fixed timeframe on the start and end
• If end is not available (alert still active), link to start and window of 1 hour

Unfortunately you cannot do arithmetic in alertmanager templates

But couldnt we set that in the generated alert file when its generated by the generator?

But couldnt we set that in the generated alert file when its generated by the generator?

We can't infer period * 1.5 for example (assuming by period you mean the time the alert is active - or you mean the for parameter? these are often just 0 or a small number)

We can't infer period * 1.5 for example (assuming by period you mean the time the alert is active - or you mean the for parameter? these are often just 0 or a small number)

I meant the for parameter. To be honest, I think just using 1h for the link is also fine. /shrug

Merging for now, can see how it works in practice :) this will be nice for looking at past alerts