This repository was archived by the owner on Sep 30, 2024. It is now read-only.
client/web/src/regression: update regression test docs#14553
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14553 +/- ##
==========================================
- Coverage 52.23% 52.22% -0.01%
==========================================
Files 1555 1555
Lines 79142 79142
Branches 7061 7117 +56
==========================================
- Hits 41337 41332 -5
- Misses 34069 34071 +2
- Partials 3736 3739 +3
|
efritz
reviewed
Oct 13, 2020
Member
Author
|
Merging because this is an improvement over what we have currently, but there is still a lot to do to make this legible (or even functional). Will send more PRs. |
This updates the regression test docs to clarify how to run these tests - these docs were really outdated / broken, I had to do a fair amount of digging. I added a 1password note with the `.envrc` file I got from Uwe, because you need to set like ~15 env vars in order to run these tests. I also removed the comments about wanting customers in the future to run this test suite - I don't think we want that anymore and that experience would not be good as running this test suite requires a working Sourcegraph dev env. The `src validate` command Uwe added to src-cli seems a lot better from a customer POV: sourcegraph/src-cli#200
8c3e4d0 to
ea65e0f
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the regression test docs to clarify how to run these tests -
these docs were really outdated / broken, I had to do a fair amount of digging.
I added a 1password note with the
.envrcfile I got from Uwe, because youneed to set like ~15 env vars in order to run these tests.
I also removed the comments about wanting customers in the future to run this
test suite - I don't think we want that anymore and that experience would not
be good as running this test suite requires a working Sourcegraph dev env. The
src validatecommand Uwe added to src-cli seems a lot better from a customerPOV: sourcegraph/src-cli#200