This repository was archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: alert owners#12358
Merged
Merged
Conversation
unknwon
reviewed
Jul 21, 2020
Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>
…toring/alert-owners
Codecov Report
@@ Coverage Diff @@
## master #12358 +/- ##
=======================================
Coverage 50.55% 50.55%
=======================================
Files 1414 1414
Lines 79119 79119
Branches 6633 6633
=======================================
Hits 39996 39996
Misses 35670 35670
Partials 3453 3453
Flags with carried forward coverage won't be shown. Click here to find out more. |
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #12358 +/- ##
=======================================
Coverage 50.55% 50.55%
=======================================
Files 1414 1414
Lines 79119 79119
Branches 6633 6633
=======================================
Hits 39996 39996
Misses 35670 35670
Partials 3453 3453
Flags with carried forward coverage won't be shown. Click here to find out more. |
Codecov Report
@@ Coverage Diff @@
## master #12358 +/- ##
=======================================
Coverage 50.55% 50.55%
=======================================
Files 1414 1414
Lines 79119 79119
Branches 6633 6633
=======================================
Hits 39996 39996
Misses 35670 35670
Partials 3453 3453
Flags with carried forward coverage won't be shown. Click here to find out more. |
emidoots
approved these changes
Jul 23, 2020
emidoots
left a comment
Member
There was a problem hiding this comment.
Great - and looks fine to me as a first approximation! We can revise individual ownership assignments later as well.
…toring/alert-owners
Codecov Report
@@ Coverage Diff @@
## master #12358 +/- ##
===========================================
+ Coverage 25.44% 50.55% +25.10%
===========================================
Files 555 1414 +859
Lines 15692 79119 +63427
Branches 4786 6633 +1847
===========================================
+ Hits 3993 39996 +36003
- Misses 11649 35670 +24021
- Partials 50 3453 +3403
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Jul 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new required
Observable.Ownerfield, with predefined owners based on 2021 engineering org, as proposed in https://github.com/sourcegraph/sourcegraph/issues/12010 for RFC-189Many of these teams don't exist yet, but it seems the ones that don't are clearly covered by an existing team in the team page (for example, backend infrastructure => current Cloud team)
Owners were assigned based on guesses, please let me know if any should change!