Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

monitoring: add observability.alerts support for sourcegraph/server#11950

Merged
bobheadxi merged 1 commit into
masterfrom
distribution/prom-alerting-server
Jul 8, 2020
Merged

monitoring: add observability.alerts support for sourcegraph/server#11950
bobheadxi merged 1 commit into
masterfrom
distribution/prom-alerting-server

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Jul 6, 2020

Copy link
Copy Markdown
Member

Stacked PR on top of https://github.com/sourcegraph/sourcegraph/pull/11832. Adds support for the functionality added in the above PR to sourcegraph/server

Closes #11473, closes #11612

VERSION=dev IMAGE=sourcegraph/server:dev cmd/server/build.sh
IMAGE=sourcegraph/server:dev dev/run-server-image.sh

@bobheadxi bobheadxi requested review from a team and emidoots July 6, 2020 06:46
@bobheadxi bobheadxi requested a review from a team as a code owner July 6, 2020 06:46
@codecov

codecov Bot commented Jul 6, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #11950 into master will decrease coverage by 2.21%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #11950      +/-   ##
==========================================
- Coverage   50.04%   47.82%   -2.22%     
==========================================
  Files        1515     1410     -105     
  Lines       88442    80037    -8405     
  Branches     6770     6670     -100     
==========================================
- Hits        44260    38279    -5981     
+ Misses      40241    38168    -2073     
+ Partials     3941     3590     -351
Flag Coverage Δ
#go 52.07% <66.66%> (-2.42%) ⬇️
#storybook 10.74% <ø> (ø)
#typescript 36.58% <ø> (ø)
#unit 47.40% <66.66%> (-2.26%) ⬇️
Impacted Files Coverage Δ
cmd/server/shared/monitoring.go 0.00% <0.00%> (ø)
cmd/frontend/internal/app/debug.go 16.98% <100.00%> (+0.46%) ⬆️
cmd/frontend/db/orgs_mock.go 0.00% <0.00%> (-100.00%) ⬇️
cmd/frontend/db/users_mock.go 0.00% <0.00%> (-100.00%) ⬇️
internal/extsvc/github/codehost.go 0.00% <0.00%> (-100.00%) ⬇️
internal/extsvc/gitlab/codehost.go 0.00% <0.00%> (-100.00%) ⬇️
...rker/internal/correlation/lsif/jsonlines/reader.go 0.00% <0.00%> (-100.00%) ⬇️
internal/authz/bitbucketserver/authz.go 0.00% <0.00%> (-89.48%) ⬇️
internal/metrics/operation.go 0.00% <0.00%> (-87.70%) ⬇️
internal/authz/gitlab/gitlab.go 0.00% <0.00%> (-86.52%) ⬇️
... and 259 more

@bobheadxi bobheadxi force-pushed the distribution/prom-alerting-server branch from b3c4ca8 to 4b9e7a9 Compare July 6, 2020 08:57
@bobheadxi bobheadxi linked an issue Jul 6, 2020 that may be closed by this pull request
monitoring: update sourcegraph/server to use prom-wrapper #11473
Closed
@bobheadxi bobheadxi force-pushed the distribution/prom-alerting-server branch from 4b9e7a9 to 7e4eff8 Compare July 8, 2020 00:19
Base automatically changed from distribution/prom-alerting to master July 8, 2020 00:20
@bobheadxi bobheadxi force-pushed the distribution/prom-alerting-server branch from 7e4eff8 to 716af0c Compare July 8, 2020 00:25
@bobheadxi bobheadxi force-pushed the distribution/prom-alerting-server branch from 716af0c to 20a6c3d Compare July 8, 2020 00:27
@bobheadxi bobheadxi changed the title monitoring: add notifications support for sourcegraph/server monitoring: add observability.alerts support for sourcegraph/server Jul 8, 2020
emidoots
emidoots approved these changes Jul 8, 2020
View reviewed changes

@emidoots emidoots left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@bobheadxi bobheadxi merged commit 840ee89 into master Jul 8, 2020
@bobheadxi bobheadxi deleted the distribution/prom-alerting-server branch July 8, 2020 04:59
@emidoots emidoots mentioned this pull request Aug 24, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@emidoots emidoots emidoots approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

monitoring: update sourcegraph/server to use prom-wrapper

2 participants

@bobheadxi @emidoots