This repository was archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: grafana email notifier support#11554
Closed
bobheadxi wants to merge 25 commits into
Closed
Conversation
…ribution/grafana-smtp
…ribution/grafana-smtp
Codecov Report
@@ Coverage Diff @@
## master #11554 +/- ##
=======================================
Coverage 47.44% 47.44%
=======================================
Files 1404 1404
Lines 79706 79706
Branches 6816 6816
=======================================
Hits 37817 37817
Misses 38310 38310
Partials 3579 3579
|
Contributor
|
Is this ready for review? Seems still have many TODOs left. If not ready yet, suggest convert to draft :)
|
Member
Author
|
Ah good idea @unknwon sorry about that! |
37 tasks
…ribution/grafana-smtp
…ribution/grafana-smtp
emidoots
reviewed
Jun 23, 2020
…ribution/grafana-smtp
…ribution/grafana-smtp
This was referenced Jun 23, 2020
Member
Author
|
Converting the draft for now due to change in plans: https://github.com/sourcegraph/sourcegraph/issues/11452#issuecomment-648652514 (will close when I have a new PR up) |
This was referenced Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/11454
This PR adds:
Implementation details:
GrafanaChangeGrafanaController, to also allow stop/restart capabilitiesQuestions:
grafana-wrapperwhile performing updategrafana-wrapperexits (exit code 1 is emitted when Grafana is SIGINT'd so we ignore it)smtp.authenticationdoes (don't seem to see an equivalent in the Grafana SMTP config) => I believe Grafana triesCRAM-MD5 PLAINin that order