This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Revert "monitoring: configure alert notifications from site config"#11479
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11479 +/- ##
==========================================
+ Coverage 46.71% 46.85% +0.14%
==========================================
Files 1397 1392 -5
Lines 79064 78777 -287
Branches 6704 6814 +110
==========================================
- Hits 36932 36911 -21
+ Misses 38622 38360 -262
+ Partials 3510 3506 -4
|
This was referenced Jun 13, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts sourcegraph/sourcegraph#11427
There seems to be some problems:
sourcegraph/serveris not properly handled (sourcegraph.sgdev.com makes a request tografana-wrapperstill and shows an error) - in general, I think opt-out cases needs a second passdot-com, configuration is getting in from somewhere that is causing the wrapper to look in the wrong place for Grafana - this is set byGRAFANA_PORT, but as far as I can know is not set by anywhere (notice30070instead of3371, as well the more obscure last error that I'm not sure I understand) - this is putting Grafana in a crash loopIt might be best to punt this to the next release - will revisit next week to see if I can get this fixed up by branch cut