Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Batch Changes: Skipped checks incorrectly show "Unknown" Check State #62133

@morgangauth

Description

@morgangauth
  • Sourcegraph version: v5+
  • Platform information: All

Steps to reproduce:

  1. Create and publish a batch change (example here)
  2. Note that any changesets that have skipped checks, or any unknown states, show up as Check State Unknown

Expected behavior:

If all checks passed except for skipped ones: the check state should show as passed.
Also - this comment suggests that if there are unknown states, the overall should be pending, when it is actually 'Unknown'

Actual behavior:

If there are any skipped checks, the check state is empty.
image

Also, if there are unknown states, the overall is still Unknown (code here):

case stateMap[btypes.ChangesetCheckStateUnknown]:
		// If there are unknown states, overall is Pending.
		return btypes.ChangesetCheckStateUnknown

If you would like immediate help on this, please email support@sourcegraph.com (you can still create the issue, but there are no SLAs on issues like there are for support requests).

/cc @sourcegraph/search-product

Metadata

Metadata

Assignees

No one assigned

    Labels

    batch-changesIssues related to Batch Changesp2Priority 2team/search-productIssues owned by the search product team

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions