You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Perforce is a bit of a special duck because it needs to use p4 for all communication with the code host, unlike most/all other sources, which can use HTTP(S) to communicate with the code host
The discussion in PR #56697 made it clear that PerforceSource should not assume the availability of p4. #56697 changed the behavior of CheckConnection; now ListRepos needs similar attention. Currently it uses PerforceDepotSyncer, which uses p4 directly. ListRepos may not be used in the same way that `CheckConnection1 is, so it may be ok with this behavior, but it bears examining.
Perforce is a bit of a special duck because it needs to use
p4for all communication with the code host, unlike most/all other sources, which can use HTTP(S) to communicate with the code hostThe discussion in PR #56697 made it clear that
PerforceSourceshould not assume the availability ofp4. #56697 changed the behavior ofCheckConnection; nowListReposneeds similar attention. Currently it usesPerforceDepotSyncer, which usesp4directly.ListReposmay not be used in the same way that `CheckConnection1 is, so it may be ok with this behavior, but it bears examining.