Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Add a Perforce client in extsvc #56782

@peterguy

Description

@peterguy

Perforce is a bit of a special duck because it needs to use p4 for all communication with the code host, unlike most/all other sources, which can use HTTP(S) to communicate with the code host

The discussion in PR #56697 made it clear that PerforceSource should not assume the availability of p4. #56697 changed the behavior of CheckConnection; now ListRepos needs similar attention. Currently it uses PerforceDepotSyncer, which uses p4 directly. ListRepos may not be used in the same way that `CheckConnection1 is, so it may be ok with this behavior, but it bears examining.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions