To address #51236 and help with other Perforce admin issues, record the output from the most recent `p4-fusion` run so that admins can examine it for errors. The output of `p4-fusion` is helpful especially when there is no obvious error because it will complete successfully but not actually sync files if there are problems with the client spec. #50860 is an example of one such situation; #43121 is another. An [issue has been opened with the `p4-fusion` project](salesforce/p4-fusion#64) to see if the behavior of `p4-fusion` can be modified, but until then, Sourcegraph admins and CE staff struggle to identify issues, and the output of the latest sync would be immensely helpful. Getting the output currently is arduous. If there is not error, it is necessary to connect to the `gitserver` instance via Terminal, capture the command being run, run it manually, and inspect the output in the terminal. Videos showing admin experience [before](https://www.loom.com/share/4fcb0f558f4e48beacdc1b12ba7d8e9c) and [after](https://www.loom.com/share/10e9d4b3ae0f4b93bd32d235482b9e4a) this PR. ## Test plan Update existing tests with new entities. ### Visual/manual testing The UX portion of this change can be tested by clicking on the kebab menu for repositories and seeing the new "Last sync output" item at the top of the menu (@sourcegraph/design - ~please give feedback on the wording, icon and positioning of the new menu item~ Thank you for your feedback! Changed the wording, icon and positioning and it looks a lot better now) <img width="758" alt="kebab menu with sync log entry" src="https://github.com/sourcegraph/sourcegraph/assets/129280/f27c5c53-6bf9-40ea-9a4b-7484730079c3"> Clicking on that "Last sync log" menu item should navigate to the repo settings "Mirroring and Cloning" page, with a new "Sync log" section added to the end. If there is no output (a synchronous clone/sync has not been run for that repository since this feature has landed), the text, "No output found" will display <img width="1004" alt="mirroring page with no output" src="https://github.com/sourcegraph/sourcegraph/assets/129280/0073def7-7049-416e-a8c1-55903866c5ac"> Otherwise, a log section will populate with the output from the sync <img width="870" alt="sync output" src="https://github.com/sourcegraph/sourcegraph/assets/129280/c6db73e8-53e3-4f87-a53a-e6754a4f5529"> (@sourcegraph/design - ~please give feedback on the LaF of the "Last sync log" section - I'm not really happy with it yet~ Thank you for your feedback; it looks a lot better now!) --------- Co-authored-by: Idan Varsano <varsanojidan@gmail.com>

Files don't sync from Perforce depot #50860

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions