Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Display Perforce Change Lists #46488

@ryanslade

Description

@ryanslade

This will be a good spike / prototype to see what the real effort would be to add a Perforce specific concept into Sourcegraph. This assumes we are still converting depots to git and is intended to see what a minimal change would look like.

If it goes well, we may have something to ship for March.

This will hopefully help us discover many unknown unknowns and clarify the complexity of things we already know we need to do.

We should keep in mind that there is at least a 50% chance we'll stop converting to git and design our abstractions in a way that can easily accommodate this.

High level changes required

Links below will be to a test Perforce depot on the dogfood instance

  • On repo landing page
    • All mentions of commit(s) should be changed to change list(s)
    • Clickable links should be changelist id, not commit sha
  • Add a change list page instead of our current commit page with a url like https://instance/owner/depot-name/-/change/1234 moving all URL changes to Perforce Change List Number Support in URLs #40330
  • Hide the metadata inserted into commit messages by p4-fusion and git-p4, eg [p4-fusion: depot-paths = "//test-perms/": change = 83725]
  • Remove the [changelist id] - prefix in commit subjects
  • Changes to commit search

Screenshot 2023-03-29 at 12 29 57

Screenshot 2023-03-29 at 12 33 24

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

Status
✅ Done - Released (available to install)

Relationships

None yet

Development

No branches or pull requests

Issue actions