Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

VS Code: Extension breaks VS Code's Account menu in a few ways #43608

@vdavid

Description

@vdavid

@eseliger's report, slightly edited for easier use:

image

The issues:

  1. The account menu icon always shows a (1) badge. It seems to be from our extension, and it's distracting for the user.
  2. The all-caps SOURCEGRAPH_AUTH looks out of place.
  3. When I click the "Sign in" menu item, nothing visible happens (and the (1) bubble stays.

Solution proposed by @vdavid:

  • Reproduce the issue
  • Figure out why the "Sign in" menu item doesn't do anything
  • Replace SOURCEGRAPH_AUTH with something better-looking (it might come from an external source, try to work with that source or the way we use it, and change this.)
  • Make sure the (1) badge disappears once the user is signed in.

/cc @sourcegraph/integrations

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions