Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Perforce: paths should start with a forward slash #41927

@pjlast

Description

@pjlast

There is a bug in the gobwas/glob package we use for path matching. The path something.js cannot be matched to the pattern **/something.js, even though this would be a valid path match.

Since we strip the depot names (and leading //) ourselves from Perforce rules, I suggest storing all Paths so that they start with a / (so for exclusion paths it would start with a -/).

/cc @sourcegraph/iam

Metadata

Metadata

Assignees

Labels

bugAn error, flaw or fault that produces an incorrect or unexpected result, or behavior.perforce

Type

No type
No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions