Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

src-cli: race conditions in campaignProgressPrinter #16195

@mrnugget

Description

@mrnugget

There are two race conditions in the campaignProgressPrinter:

  1. We found a workaround for the first one here: Fix status bar updates getting lost src-cli#389 (comment) But we should fix it properly.
  2. I discovered a second one: campaignProgressPrinter reads and mutates its own state across multiple calls of PrintStatuses. These calls can happen in separate goroutines, which might leak to concurrent accesses of the same data structures (and caused a panic for me locally)

Metadata

Metadata

Assignees

Labels

batch-changesIssues related to Batch ChangesbugAn error, flaw or fault that produces an incorrect or unexpected result, or behavior.estimate/2dsrc-cli

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions