Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

test validates instance#687

Merged
uwedeportivo merged 31 commits into
masterfrom
validate_instance
Nov 10, 2020
Merged

test validates instance#687
uwedeportivo merged 31 commits into
masterfrom
validate_instance

Conversation

@uwedeportivo

@uwedeportivo uwedeportivo commented May 14, 2020

Copy link
Copy Markdown
Contributor

adds a validation step to a test run that also uses gitserver ssh keys

implements https://github.com/sourcegraph/sourcegraph/issues/9722

companion PR sourcegraph/src-cli#200

@uwedeportivo uwedeportivo marked this pull request as draft May 14, 2020 18:54
@uwedeportivo uwedeportivo marked this pull request as ready for review June 30, 2020 23:17
Comment thread tests/integration/restricted/test.sh Outdated
Comment thread tests/integration/restricted/validate.star Outdated
@uwedeportivo

Copy link
Copy Markdown
Contributor Author

ok, switched to json spec for validation, give it another look

@bobheadxi bobheadxi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@uwedeportivo uwedeportivo merged commit a8bd7c4 into master Nov 10, 2020
@uwedeportivo uwedeportivo deleted the validate_instance branch November 10, 2020 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants