Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Use server proxy for web mentions in Cody Web#5085

Merged
vovakulikov merged 2 commits into
mainfrom
cc/url-mention-server
Aug 2, 2024
Merged

Use server proxy for web mentions in Cody Web#5085
vovakulikov merged 2 commits into
mainfrom
cc/url-mention-server

Conversation

@camdencheek

@camdencheek camdencheek commented Aug 1, 2024

Copy link
Copy Markdown
Member

This updates the web context provider to optionally use the new endpoint in the GraphQL API (introduced here) to fetch web context in cody web to get around CORS issues.

Test plan

Tested dev build against local Sourcegraph instance. Also tested that web mentions still work in VSCode.
screenshot-2024-08-01_14-40-53@2x

@camdencheek camdencheek force-pushed the cc/url-mention-server branch from 5ac835e to 80f146d Compare August 1, 2024 21:01
@camdencheek camdencheek marked this pull request as ready for review August 1, 2024 21:34
@camdencheek camdencheek requested review from a team and vovakulikov August 1, 2024 21:34
@vovakulikov

Copy link
Copy Markdown
Contributor

@camdencheek merging this since we still need to bump the version in the Sourcegraph client. Change seems very safe since only Cody Web uses new Web URL mention logic

@vovakulikov vovakulikov merged commit 0112ce6 into main Aug 2, 2024
@vovakulikov vovakulikov deleted the cc/url-mention-server branch August 2, 2024 02:06
@sqs

sqs commented Aug 2, 2024

Copy link
Copy Markdown
Member

this is awesome, thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants