This repository was archived by the owner on Aug 1, 2025. It is now read-only.
Integrate VSCode Cody with server-side Context API#4840
Merged
Conversation
added 17 commits
July 11, 2024 17:35
janhartman
reviewed
Jul 17, 2024
| type LogEventResponse = unknown | ||
|
|
||
| interface ChatIntentResponse { | ||
| chatIntent: { |
Contributor
There was a problem hiding this comment.
do we need these outer objects? (same in RankContextResponse)
Contributor
Author
There was a problem hiding this comment.
I think this is caused by how GraphQL serializes stuff (it has it's own outer wrapper with a single property, and we unpack the inner response?
| /** | ||
| * Experimental API. | ||
| */ | ||
| export interface InputContextItem { |
Contributor
There was a problem hiding this comment.
if you don't put Input in the name do we have a conflict with another type? It seems a bit awkwardly named TBH.
Contributor
Author
There was a problem hiding this comment.
We have a clash between a type ContextItem and input ContextItem in GraphQL, but both of those are new types, so if you think that makes sense, I can use input ContextItem (i.e. this one) and something else for output (ContextItemResult? CodyContextItem? ContextDocument?)
janhartman
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Client-side integration of https://github.com/sourcegraph/sourcegraph/pull/63789 for VSCode:
Currently, for all added backend calls:
Related to AI-128.
Test plan