Add types for GitHub plugin. #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
reviewed
Feb 27, 2018
Contributor
wchargin
left a comment
There was a problem hiding this comment.
LGTM modulo small comments below.
| subpayload: PullRequestPayload | IssuePayload | CommentPayload | UserPayload, | ||
| }; | ||
|
|
||
| export type EdgeType = "AUTHOR" | "REFERENCE"; |
Contributor
There was a problem hiding this comment.
As discussed: inclusion and co-inclusion will both fall under the REFERENCE type. That is, an issue REFERENCEs its comments, and the comments also REFERENCE their enclosing issues (resp. PR). We don’t see any reason why this should cause ambiguity, because an issue cannot otherwise reference a comment: it has no body in which to do so.
We’re punting on close/reopen actions for now.
backend/githubPlugin.js
Outdated
| @@ -0,0 +1,45 @@ | |||
| // @flow | |||
|
|
|||
| import type {ID, GraphNode, GraphEdge} from "./graph"; | |||
backend/githubPlugin.js
Outdated
|
|
||
| import type {ID, GraphNode, GraphEdge} from "./graph"; | ||
|
|
||
| export const GITHUB_PLUGIN_NANE = "sourcecred/github-beta"; |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with @wchargin
Based on discussion at #29