fix(search): Fix issue with filtering on generic git repo indexed from http/https #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cess and search For generic git host repos with HTTP/HTTPS URLs, the gitConfig metadata was missing. This caused issues because: 1. After cloning, remote.origin.url is unset for security reasons 2. Zoekt uses gitConfig (specifically zoekt.name) to identify repos 3. Without gitConfig, zoekt couldn't properly identify the repo name This fix adds proper gitConfig metadata (zoekt.name, zoekt.web-url, etc.) to compileGenericGitHostConfig_url, similar to how other code hosts handle it. Fixes SOU-218 Co-authored-by: michael <michael@sourcebot.dev>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brendan-kellam
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
gitConfigmetadata to generic git host URL connections to enable proper Zoekt indexing and file access.For generic git host repos with HTTP/HTTPS URLs,
gitConfigmetadata (includingzoekt.name) was missing. After cloning,remote.origin.urlis unset for security, leaving Zoekt with no way to determine the repo name. This prevented search and file access for these repos. Local file-based repos worked because they retainedremote.origin.url.Fixes #741
Linear Issue: SOU-218