Conversation
|
Thanks for doing this! Will have a look and do a test run if I have the time during next week! |
kebbet
left a comment
There was a problem hiding this comment.
Just read the code, have not tested it, don't know how to fetch a pull request... 😂
|
@kebbet Appreciate that one of your main points is that Barring any better words, how about |
Much clearer with |
|
Side note, I recently hooked up my Visual Studio Code to GitHub, and all your comments have appeared directly in my editor. Super neat! |
Nice, I tried it too and can now see PR's and comments! Thanks! |
|
Apologies, I clicked the re-review button I'm not sure it did anything? Made changes, if you're happy I can merge this in. Only uncommented thing is class-multisite.php:86, the multisite definition of email disabling is different to reflect disabling all multisite emails. |
kebbet
left a comment
There was a problem hiding this comment.
Small things. Looks nice overall!
|
Fab - will merge in. Thanks for all your help! 😄 |
Issue #51 raised by @kebbet highlights an important oversight that doesn't follow the standard of the rest of the WordPress administration dashboard, being that not only are labels missing from checkboxes, but the label-for in the settings key column were left undefined.
This PR adjusts the generation functions to make them less of a catch-all approach, and also allows the group of sporadic check boxes to be group together. The PR affects both single-site and multisite settings equally.
@kebbet if you wouldn't mind verifying if this is what you were expecting, especially as it adds more labels that will ultimately need translating and I don't want to add unnecessary burden if it's wrong.
Settings Checkbox Group
Before
After
Additionals
Additional adjustments