Enable music sharing through a GridItemAdapter's long click#95
Merged
Conversation
…dk version to 21)
… material dialog (prep work for later copy)
… MusicService for information and a Share helper function
Contributor
Author
|
I forgot to include an image before, here is the new behavior in action. Nothing groundbreaking but surely helpful for quick sharing.
|
Member
|
Hey, cool thanks, I'll test this and if everything looks good I'll put it together with my changes into a new version soon. Later, I'll add support for local playlists and then probably replace the long click with a menu and move the share option inside there 👍 |
Contributor
Author
|
Sounds good thanks :) In the meantime, if I can help with anything, that'd be my pleasure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nabend!
I'm a real enjoyer of your application and I thought it was missing the option to share non-local content directly from the grid view, ie: without starting the music and opening up the Fragment to find the share button.
I hope these changes can find their way into the official build of the application. I also updated some dependencies and gradle build files as they were getting old and I figured why not.
Old behavior:
Long press on a grid item: nothing
New behavior:
Long press on a grid item:
This has been tested on my side with the Soundcloud plugin.