refactor: enhance makeSureCallable function with context support#77
Merged
refactor: enhance makeSureCallable function with context support#77
Conversation
Updated the makeSureCallable function to accept a context parameter, allowing for cancellation checks during command validation. This change improves responsiveness to context cancellation and enhances error handling. Additionally, updated related tests to utilize context, ensuring consistent behavior across various scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the makeSureCallable function to accept a context parameter, allowing for cancellation checks during command validation. This change improves responsiveness to context cancellation and enhances error handling. Additionally, updated related tests to utilize context, ensuring consistent behavior across various scenarios.