Skip to content

feat: use tracing-kit#110

Merged
soulteary merged 1 commit intomainfrom
feat/use-tracing-kit
Jan 26, 2026
Merged

feat: use tracing-kit#110
soulteary merged 1 commit intomainfrom
feat/use-tracing-kit

Conversation

@soulteary
Copy link
Copy Markdown
Owner

@soulteary soulteary commented Jan 26, 2026

Note

Introduces optional distributed tracing powered by tracing-kit (OpenTelemetry) and wires it into startup/shutdown.

  • New internal/tracing package: init/shutdown, span helpers, W3C context inject/extract, and tests
  • CLI/ENV support: --tracing-enabled, --otlp-endpoint, --tracing-service-name with corresponding env keys and defaults
  • webhook.go: initialize tracing (includes service version), log status, and graceful tracer shutdown on exit
  • Dependencies updated in go.mod/go.sum (add tracing-kit, OTel libs); Go patch version bumped

Written by Cursor Bugbot for commit 827e95d. This will update automatically on new commits. Configure here.

@soulteary soulteary merged commit 6b5a545 into main Jan 26, 2026
4 checks passed
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on February 12

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

}
}

return nil
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracing state inconsistent when initialization fails

Medium Severity

When tracingkit.InitTracer fails, the Init function returns an error but leaves tracingEnabled set to true. Since webhook.go only logs a warning and continues execution when Init fails, subsequent calls to IsEnabled() return true and functions like StartSpan and Shutdown attempt to use the uninitialized tracing system. This creates an inconsistent state where tracing appears enabled but isn't actually functional.

Additional Locations (1)

Fix in Cursor Fix in Web

@soulteary soulteary deleted the feat/use-tracing-kit branch March 12, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant