Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Upgrades Jest to v30, aligns related configurations, and adds a global nock cleanup to prevent memory warnings.
- Bumps
jestto v30.0.0 and updatests-jest - Introduces a global teardown for nock interceptors
- Adjusts Jest config with worker memory limit and mock cleanup settings
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/setupFiles/nock-cleanup.ts | Adds an afterAll hook to clean and restore nock between test files |
| package.json | Upgrades jest and ts-jest versions |
| jest.config.ts | Adds nock-cleanup to setupFilesAfterEnv, sets workerIdleMemoryLimit and clearMocks |
Comments suppressed due to low confidence (2)
jest.config.ts:25
- [nitpick] The
clearMocks: trueoption only resets mock call history and instances, but does not restore original implementations. If the goal is to restore mocks to their originals, consider usingrestoreMocks: trueor update the comment to reflect the behavior ofclearMocks.
// Jest 30 compatibility settings - less aggressive cleanup to preserve mocks
package.json:121
- You’ve upgraded Jest to v30 but kept
ts-jestat v29. Ensure thatts-jestsupports Jest 30 or bump it to a compatible major version to avoid compatibility issues.
"ts-jest": "^29.4.0",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Jest to v30, aligns related configurations, and adds a global nock cleanup to prevent memory warnings.
jestto v30.0.0 and updatests-jest