Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades ESLint to version 9.x and updates related configurations and dependency versions. It also refactors several import statements to use type-only imports and adjusts some logging and error handling patterns.
- Converted many regular imports to type-only imports where applicable.
- Updated dependency versions and ESLint configuration (moving from .eslintrc.js to eslint.config.js).
- Made minor code refinements in logging and error handling.
Reviewed Changes
Copilot reviewed 114 out of 114 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/cherrypickAndCreateTargetPullRequest/*.ts | Refactored imports to use type-only syntax. |
| src/lib/apm.ts | Updated ts-expect-error comments and changed fallback for NODE_ENV. |
| src/backportRun.ts, src/entrypoint.api.ts, src/lib/author.ts, etc. | Updated type-only imports and minor logging improvements. |
| package.json | Upgraded ESLint and related dependencies; added caching to the lint command. |
| jest.testSequencer.js, jest.config.all.ts | Removed custom test sequencer configuration. |
| eslint.config.js, .eslintrc.js | Replaced legacy ESLint configuration with the new file. |
| .vscode/settings.json, .eslintignore | Updated VS Code settings to enable format-on-save and cleaned up ignore patterns. |
Comments suppressed due to low confidence (2)
.eslintrc.js:1
- The removal of .eslintrc.js implies that all ESLint configurations have been migrated to eslint.config.js. Please ensure that any custom rules or configurations previously defined in .eslintrc.js are fully replicated in the new setup.
Entire file removed
src/lib/apm.ts:6
- The change from a logical OR (||) to nullish coalescing (??) means an empty string for NODE_ENV will no longer trigger the fallback value. Please confirm that an empty string is acceptable, or consider using a fallback that treats empty strings as falsy if that is desired.
const environment = process.env.NODE_ENV ?? 'production-cli';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades ESLint to version 9.x and updates related configurations and dependency versions. It also refactors several import statements to use type-only imports and adjusts some logging and error handling patterns.