Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies how the package version is retrieved by replacing a hard-coded string with a dynamic import from package.json, and updates tests to reflect this change.
- Dynamically import the version value from package.json instead of hardcoding it.
- Update tests to set and record the unmapped version before applying a mock value.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/packageVersion.ts | Uses the package.json import to dynamically retrieve the version. |
| src/test/setupFiles/automatic-mocks.ts | Adjusts the mocks to accommodate the change in version retrieval. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/test/setupFiles/automatic-mocks.ts:25
- Reassigning an exported constant may produce confusion and unintended side effects. Consider refactoring the test to use dependency injection or another strategy that avoids modifying a constant export.
packageVersionModule.PACKAGE_VERSION = '1.2.3-mocked';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrieve package version from package.json at runtime instead of extracting at build time