Modify script to work correctly under branch protection settings#132
Merged
Modify script to work correctly under branch protection settings#132
Conversation
bearmini
reviewed
Jul 23, 2025
|
|
||
| # Push feature branch and create PR (force push to overwrite existing branch) | ||
| git push --force-with-lease origin "$branch_name" | ||
| gh pr create --title "Bump version to $version" \ |
Collaborator
There was a problem hiding this comment.
ここまで実行して gh コマンドがインストールされてない環境だと PR の作成に失敗してしまい、手作業で PR を作り直さないといけなくなってしまうと思うので、スクリプトの最初の方で
command -v gh > /dev/null 2>&1 || {
echo "'gh' is required."
echo "Install gh by following the instructions: https://github.com/cli/cli#installation"
exit 1
}
というような感じで gh コマンドが使えるかどうかをチェックしてあげるとより親切かもしれません。
（厳密にいうと git コマンドも同様ですが、git コマンドが無いと最初の clone 時点で失敗するので実害が無いので現時点ではチェックしてない感じですね）
Contributor
Author
There was a problem hiding this comment.
遅くなりましたが、gh コマンドのチェックを最初に追加しました
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLIリリース用スクリプトを修正しました。
homebrew-soracom-cliリポジトリに直接プッシュを禁止するブランチ保護が設定されるようになったため、トピックブランチを作成してプルリクエストを作成するようにスクリプト処理を変更しました。