BIOS upgrade support in sonic_installer#570
Closed
paavaanan wants to merge 3 commits intosonic-net:masterfrom
Closed
BIOS upgrade support in sonic_installer#570paavaanan wants to merge 3 commits intosonic-net:masterfrom
paavaanan wants to merge 3 commits intosonic-net:masterfrom
Conversation
lguohan
reviewed
Jul 8, 2019
sonic_installer/main.py
Outdated
| import urllib | ||
| import tempfile | ||
| import subprocess | ||
| import sonic_platform.chassis |
Contributor
There was a problem hiding this comment.
not all platform has this module implemented, so this will break all platforms that do not have this module defined. we need to check the module availability.
Contributor
Author
There was a problem hiding this comment.
Addressed in new commit...
Contributor
There was a problem hiding this comment.
Thanks. We will need to do this until all vendors have transitioned to the new platform API.
lguohan
reviewed
Jul 9, 2019
| run_command( | ||
| 'mount ' + squashfs_path + ' ' + tmpdir + \ | ||
| ' -t squashfs -o loop') | ||
| status = chassis.install_component_firmware(component_name, tmpdir) |
Contributor
There was a problem hiding this comment.
I do not see the bios firmware name in the tmpdir. should that be a filename?
Contributor
Author
There was a problem hiding this comment.
- Each vendor, do have a different BIOS filename. So, if we attempt to pass a filename instead of tmpdir we end-up with multiple combinations. To avoid this, we pass only mounted squashfs location as tmpdir.
- Now, individual vendors do construct their BIOS image path according to their naming standards form the mounted filesystem. You can see the implementation below:
- https://github.com/Azure/sonic-buildimage/blob/0d8c1b2463a677a477e76ef395ae64569e43508f/platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py#L161
Contributor
There was a problem hiding this comment.
it should be at least under /usr/sonic/dev/{platform} folder.
Contributor
Author
There was a problem hiding this comment.
- It is already addresed. DellEMC BIOS file do reside in following directory:
/usr/share/sonic/device/x86_64-dell_s6100_c2538-r0/bin/ BIOS filepath - BIOS filename is fetched from chassis.py. BIOS filename
- Do you need any change here?
lguohan
reviewed
Jul 9, 2019
Contributor
Author
|
closing this PR due to change in BIOS update procedure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- New command output (if the output of a command-line utility has changed)
-->