[202205] Fix issue: unconfigured PGs are displayed in watermarkstat#2568
Merged
liat-grozovik merged 2 commits intosonic-net:202205from Dec 26, 2022
Merged
Conversation
Root cause: all the PGs between minimal and maximal indexes are displayed Originally, watermark counters were enabled for all PGs, so there is no issue Now, watermark counters are enabled only for PGs with buffer configured, eg. if PG 0/2/3/4/6, is configured, PG 0-6 will be displayed, which gives users a feeling that PG 7 is lost, which is confusing Fix: display valid PGs only Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This is to cherry-pick #2556 to 202205
Fix issue
All the PGs between minimal and maximal indexes are displayed regardless of whether they are configured.
Originally, watermark counters were enabled for all PGs, so there is no issue.
Now, watermark counters are enabled only for PGs with buffer configured, eg. if PG 0/2/3/4/6, is configured, PG 0-6 will be displayed, which is confusing by giving users a feeling that PG 7 is lost
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
Display valid PGs only
How to verify it
Manually test and unit test.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
PG1won't be displayed if it is not configured