Skip to content

[202205] Revert "Ignore removing switch for mellanox platform due to known limitation (#1216)"#1231

Merged
yxieca merged 1 commit intosonic-net:202205from
Junchao-Mellanox:202205-revert-10f37ef
Apr 24, 2023
Merged

[202205] Revert "Ignore removing switch for mellanox platform due to known limitation (#1216)"#1231
yxieca merged 1 commit intosonic-net:202205from
Junchao-Mellanox:202205-revert-10f37ef

Conversation

@Junchao-Mellanox
Copy link
Copy Markdown
Contributor

What I did?

This reverts commit 10f37ef.

Why I did this?

This commit introduces a race condition with would cause syncd crash. The issue happens when:

  1. Syncd.m_sn has been freed
  2. SAI send a port state change notification which will access Syncd.m_sn ===> causes crash

@yxieca yxieca merged commit 7f6abdd into sonic-net:202205 Apr 24, 2023
@Junchao-Mellanox Junchao-Mellanox deleted the 202205-revert-10f37ef branch April 28, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants