[202205][Cherry-pick][asan] suppress the static variable leaks#1159
Merged
bingwang-ms merged 1 commit intosonic-net:202205from Jan 3, 2023
Merged
[202205][Cherry-pick][asan] suppress the static variable leaks#1159bingwang-ms merged 1 commit intosonic-net:202205from
bingwang-ms merged 1 commit intosonic-net:202205from
Conversation
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1159 in repo sonic-net/sonic-sairedis |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* [asan] suppress the static variable leaks This is to suppress ASAN false positives for static variables. For example, the ServiceMethodTable::m_slots is sometimes reported as leaked. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com> * [asan] add missing SWSS_LOG_ENTER() Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
e24d519 to
f7f47fb
Compare
Contributor
Author
|
Pending #1170 to pass LGTM check |
yxieca
approved these changes
Dec 14, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@Yakiv-Huryk please address the build failure. |
Contributor
Author
The build is failing due to the "Install gcovr 5.0 with recursive fix" CI step failure. |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@Yakiv-Huryk can you pls summarize what are the failures observed? looks to me the tests are not stable as your change should not affect that. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick from #1085
This is to suppress ASAN false positives for static variables. For example, the ServiceMethodTable::m_slots is sometimes reported as leaked.