Skip to content

Ported Marvell armhf build on amd64 host for debian buster to use cross-comp…#88

Merged
lguohan merged 4 commits intosonic-net:masterfrom
gregshpit:master
Nov 8, 2021
Merged

Ported Marvell armhf build on amd64 host for debian buster to use cross-comp…#88
lguohan merged 4 commits intosonic-net:masterfrom
gregshpit:master

Conversation

@gregshpit
Copy link
Copy Markdown
Contributor

…ilation instead of qemu emulation

…ilation instead of qemu emulation

Motivation:
Current armhf Sonic build on amd64 host uses qemu emulation. Due to the nature of the emulation it takes a very long time, about 22-24 hours to complete the build. The change I did to improve the building time ports Sonic armhf build on amd64 host for Marvell platform for debian buster to use cross-compilation on arm64 host for armhf target. The overall Sonic armhf building time using cross-compilation is about 6 hours.

The Sonic configure and build for the armhf cross-compilation is as following:
NOJESSIE=1 NOSTRETCH=1 BLDENV=buster CROSS_BLDENV=1 make configure PLATFORM=marvell-armhf PLATFORM_ARCH=armhf
NOJESSIE=1 NOSTRETCH=1 BLDENV=buster CROSS_BLDENV=1 make target/sonic-marvell-armhf.bin

Sonic module should check if $CROSS_BUILD_ENVIRON is 'y' to make sure that it is cross-compilation build.

@gregshpit
Copy link
Copy Markdown
Contributor Author

Dear reviewers,

Long time has passed since this PR was raised. Please make progress on the review.

Thanks,

Gregory

Rebased with the module's master repository
@gregshpit
Copy link
Copy Markdown
Contributor Author

Hi, please review and merge this PR. It was raised already 4 months ago.
Thanks.

Gregory


KLISH_VERSION = 2.1.4
PYTHONVER=3.7
PYTHONVER=2.7
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this changed back to 2.7?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asked to apply this change as rebasing to the sonic-mgmt-framework master. But now I see
that I was probably misled, the master branch did not change PYTHONVER.
I'll make an inquiry and get back to you.

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 14, 2021

@gregshipit, can you check the build failure?

Discarded the last commit as incorrect
Fixed previous commit to fully discard changes in the skipped commit.
@gregshpit
Copy link
Copy Markdown
Contributor Author

@gregshipit, can you check the build failure?

I discarded the last mistaken commit and now the build finished successfully.

@radha-danda
Copy link
Copy Markdown

@lguohan, build issue is resolved and now all checks are passing file. Please review the changes

@radha-danda
Copy link
Copy Markdown

@lguohan, can this PR me merged please?

@lguohan lguohan merged commit e337588 into sonic-net:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants