Subscription callbacks for acl and interface app modules#86
Merged
anand-kumar-subramanian merged 6 commits intosonic-net:masterfrom May 24, 2023
Merged
Conversation
* Implemented translateSubscribe() and processSubscribe() methods in AclApp and IntfApp. Mapping is based on the existing processGet() implementation. This may not be accurate since both the app modules have not been updated since long time. But it will be useful for testing the subscription feature. * Current IntfApp supports only physcial ports in get/set operations. Same limitation is applicable for subscription as well. * Added utilities for processing the path objects and help prepare the translateSubscribe() resposne. * Added gotest helper functions to call translateSubscribe() and verify the responses. Added gotest cases to verify different openconfig-acl and openconfig-interfaces yang paths. * Fixed incorrect paths & payloads used by the existing AclApp get/set test cases. Signed-off-by: Sachin Holla <sachin.holla@broadcom.com>
0708f02 to
3c81762
Compare
tomek-US
reviewed
May 17, 2023
tomek-US
left a comment
There was a problem hiding this comment.
Thx for all those changes.
It was a pleasure to review this code.
A few mostly cosmetic comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented translateSubscribe() and processSubscribe() methods in AclApp and IntfApp. Mapping is based on the existing processGet() implementation. This may not be accurate since both the app modules have not been updated since long time. But it will be useful for testing the subscription feature.
Current IntfApp supports only physcial ports in get/set operations. Same limitation is applicable for subscription as well.
Added utilities for processing the path objects and help prepare the translateSubscribe() resposne.
Added gotest helper functions to call translateSubscribe() and verify the responses. Added gotest cases to verify different openconfig-acl and openconfig-interfaces yang paths.
Fixed incorrect paths & payloads used by the existing AclApp get/set test cases.
Part of gNMI Subscription enhancements described in sonic-net/SONiC#1287