Path validator API implementation to validate the gnmi path#76
Merged
anand-kumar-subramanian merged 5 commits intosonic-net:masterfrom May 22, 2023
Merged
Conversation
ndas7
reviewed
May 10, 2023
ndas7
reviewed
May 10, 2023
ndas7
reviewed
May 16, 2023
ca708a6 to
483852a
Compare
ndas7
reviewed
May 19, 2023
Contributor
ndas7
left a comment
There was a problem hiding this comment.
LGTM. A few readability comments according to the Go Style Guide.
ndas7
approved these changes
May 22, 2023
anand-kumar-subramanian
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path validator API implementation to validate the gnmi path, and added following methods.
NewPathValidator() : to create pathValidator type to validate the gnmi path and add the missing module prefix and key names and wild card values in the gnmi path based on the given PathValidatorOpt
Validate() : to validate the path and add the module prefix / wild card keys in the gnmi path based on the given PathValidatorOpt while creating the path validator.
Required for the subscription enhancements as described in HLD sonic-net/SONiC#1287