Avoid duplicate ocbinds schema loading#73
Merged
anand-kumar-subramanian merged 4 commits intosonic-net:masterfrom May 11, 2023
Merged
Avoid duplicate ocbinds schema loading#73anand-kumar-subramanian merged 4 commits intosonic-net:masterfrom
anand-kumar-subramanian merged 4 commits intosonic-net:masterfrom
Conversation
Introduced a new function ocbinds.GetSchema(), which is equivalent of the generated function ocbinds.Schema(), but loads the schema only once. Translib request_binder and transformer are changed to use the new GetSchema() function. Avoids duplicate schema loads during init. Signed-off-by: Sachin Holla <sachin.holla@broadcom.com>
sallylsy
reviewed
May 3, 2023
sallylsy
approved these changes
May 9, 2023
anand-kumar-subramanian
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new function
ocbinds.GetSchema(), which is equivalent of the generated functionocbinds.Schema(), but loads the schema only once. Translib request_binder and transformer components will use the new function. Avoids duplicate schema loads during init.